-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Add Nix Store volume support #524
Conversation
The error on the pipeline does not seem related. Any idea what might have caused it? |
This is indeed not related. See:
|
Any news on this? |
What is the use case for this? It seems like this should already be possible using |
It fails to run automatically; so we would need to pass it to every time we call cross when using NixOS. |
What exactly fails to run? I'm not really familiar with NixOS, can you explain in more detail which packages need to be available/mounted in the container and why? |
I am unsure if you know what NixOS is. So please take a look at How Nix works document. It explains how the Nix store works and more. In summary, without the patch, |
Okay, I understand now what the Nix store is/does.
I'm still not sure what specifically the problem is though. Let me know if the following assumption is correct. Let's say we are talking about the
|
Exactly, your understanding is correct. Doing the mount inside the container allows it to run successfully. |
Just one more question. Does Nix use some kind of customized version of |
Yes, it does. See rustup. |
bors r+ |
524: docker: Add Nix Store volume support r=reitermarkus a=otavio When running inside NixOS or using Nix packaging we need to add the Nix Store to the running container so it can load the needed binaries. Signed-off-by: Otavio Salvador <[email protected]> Co-authored-by: Otavio Salvador <[email protected]>
Build failed: |
Should I do anything on my side on this one? |
fix the fmt error and it should be good to go :) https://github.com/cross-rs/cross/runs/5578287402?check_suite_focus=true#step:4:10 bors d+ edit:: Actually, delegation doesn't work well when new commits dismisses reviews :/ |
✌️ otavio can now approve this pull request. To approve and merge a pull request, simply reply with |
When running inside NixOS or using Nix packaging we need to add the Nix Store to the running container so it can load the needed binaries. Signed-off-by: Otavio Salvador <[email protected]>
bors r+ |
👎 Rejected by too few approved reviews |
yeah, thought so. Should maybe fix that in upstream bors (or disable dismissal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded: |
I think there was an issue for this, this should pr should close that |
When running inside NixOS or using Nix packaging we need to add the Nix
Store to the running container so it can load the needed binaries.
Signed-off-by: Otavio Salvador [email protected]